<html>
<head><meta charset="utf-8"><title>x.py concerns · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html">x.py concerns</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="197700338"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197700338" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197700338">(May 15 2020 at 14:35)</a>:</h4>
<p>Hey <span class="user-mention" data-user-id="116122">@simulacrum</span> just collecting my thoughts from the discussion in the steering meeting:</p>
<ul>
<li>config.toml is not obvious (perhaps make x.py error until they set it up)?</li>
<li>disk space usage</li>
<li>when to do a full 2-stage build</li>
<li>building with system llvm (and when not to)</li>
</ul>



<a name="197700510"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197700510" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197700510">(May 15 2020 at 14:36)</a>:</h4>
<p>I'd add, when using <code>--keep-stage 1</code> is needed and may improve compilation times</p>



<a name="197700575"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197700575" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197700575">(May 15 2020 at 14:36)</a>:</h4>
<p>when it may be problematic to do so</p>



<a name="197700637"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197700637" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197700637">(May 15 2020 at 14:37)</a>:</h4>
<p>some people use <code>src/libstd</code> what does that mean?</p>



<a name="197700640"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197700640" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197700640">(May 15 2020 at 14:37)</a>:</h4>
<p>Quoting varkor: </p>
<blockquote>
<p>this is probably also tangential, but it could be worth considering a prompt the first time x.py is run, which walks a new contributor through setting up config.toml without having to wade through all the uncommon options — just some simple questions for a "quick start"</p>
</blockquote>



<a name="197700774"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197700774" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197700774">(May 15 2020 at 14:38)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116266">Santiago Pastorino</span> <a href="#narrow/stream/131828-t-compiler/topic/x.2Epy.20concerns/near/197700637">said</a>:</p>
<blockquote>
<p>some people use src/libstd what does that mean?</p>
</blockquote>
<p>wouldn't be better to use this under a flag which is more explicit, like <code>--up-to src/libstd</code>?</p>



<a name="197701009"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197701009" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197701009">(May 15 2020 at 14:39)</a>:</h4>
<p><code>./x.py build --stage 1 --keep-stage 1 src/libstd</code> doesn't that read weird? what is the meaning of that?</p>



<a name="197701141"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197701141" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197701141">(May 15 2020 at 14:40)</a>:</h4>
<p>I already know and understand most of this stuff but I was confused about some of these things at some point</p>



<a name="197705024"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197705024" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197705024">(May 15 2020 at 15:05)</a>:</h4>
<p>side note that selecting indivudal tests could be improved I think relatively easily</p>



<a name="197705087"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197705087" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197705087">(May 15 2020 at 15:05)</a>:</h4>
<p>I'd like to see <code>x.py test src/test/ui/foo.rs</code> just work</p>



<a name="197705139"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197705139" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197705139">(May 15 2020 at 15:06)</a>:</h4>
<p>it would probably just translate to a <code>--test-args</code> call</p>



<a name="197705168"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197705168" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> varkor <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197705168">(May 15 2020 at 15:06)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116009">nikomatsakis</span> <a href="#narrow/stream/131828-t-compiler/topic/x.2Epy.20concerns/near/197705087">said</a>:</p>
<blockquote>
<p>I'd lik to see <code>x.py test src/test/ui/foo.rs</code> just work</p>
</blockquote>
<p>it does, doesn't it?</p>



<a name="197705254"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197705254" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> varkor <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197705254">(May 15 2020 at 15:06)</a>:</h4>
<p>it used not to, but there were some PRs not so long ago that added some special-casing for these sorts of invocations</p>



<a name="197705270"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197705270" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197705270">(May 15 2020 at 15:06)</a>:</h4>
<p>it's supposed to</p>



<a name="197705329"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197705329" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197705329">(May 15 2020 at 15:07)</a>:</h4>
<p>ohh interesting, pretty sure that's not documented on rustc-dev-guide</p>



<a name="197705332"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197705332" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> varkor <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197705332">(May 15 2020 at 15:07)</a>:</h4>
<p>maybe those changes should have been publicised a bit more</p>



<a name="197705367"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197705367" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> varkor <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197705367">(May 15 2020 at 15:07)</a>:</h4>
<p>both on rustc-dev-guide and by cc'ing compiler-contributors</p>



<a name="197705506"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197705506" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197705506">(May 15 2020 at 15:08)</a>:</h4>
<p>it may be a good idea to not merge these PRs if we lack something that explains these changes on rustc-dev-guide maybe ...</p>



<a name="197708842"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197708842" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Tshepang Lekhonkhobe <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197708842">(May 15 2020 at 15:28)</a>:</h4>
<p>that would introduce more friction for contributors... would be more easy if dev guide was part of rustc repo (which is maybe not a bad idea)</p>



<a name="197709085"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197709085" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197709085">(May 15 2020 at 15:30)</a>:</h4>
<p><span class="user-mention" data-user-id="119529">@Tshepang Lekhonkhobe</span> we have thought about that, but then the time to land a single PR increases to days due to CI</p>



<a name="197709109"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197709109" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197709109">(May 15 2020 at 15:30)</a>:</h4>
<p>and then who knows how many links will break while in the queue</p>



<a name="197709627"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197709627" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Tshepang Lekhonkhobe <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197709627">(May 15 2020 at 15:35)</a>:</h4>
<p>if it encourages rustc contributors to add content, seems like a big win</p>



<a name="197709642"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197709642" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Tshepang Lekhonkhobe <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197709642">(May 15 2020 at 15:35)</a>:</h4>
<p>links break regardless</p>



<a name="197709707"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197709707" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197709707">(May 15 2020 at 15:35)</a>:</h4>
<p>fair, it's worth thinking about, but I think there are also challenges</p>



<a name="197709722"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197709722" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Tshepang Lekhonkhobe <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197709722">(May 15 2020 at 15:35)</a>:</h4>
<p>... them breaking during rustc CI would ensure they are kept fresh</p>



<a name="197709840"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197709840" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Tshepang Lekhonkhobe <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197709840">(May 15 2020 at 15:36)</a>:</h4>
<p>yeah, pros and cons</p>



<a name="197709933"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197709933" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197709933">(May 15 2020 at 15:37)</a>:</h4>
<p>I'm not sure if I prefer to merge rustc-dev-guide into rust repo, if people that review PRs ask for documentation on rustc-dev-guide would be enough</p>



<a name="197709934"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197709934" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197709934">(May 15 2020 at 15:37)</a>:</h4>
<p>but</p>



<a name="197709961"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197709961" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197709961">(May 15 2020 at 15:37)</a>:</h4>
<p>if we were integrating rustc-dev-guide or something</p>



<a name="197709994"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197709994" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197709994">(May 15 2020 at 15:37)</a>:</h4>
<p>I wonder if it's possible to make r+ use some kind of heuristic to avoid most or all the checks in cases like this</p>



<a name="197712966"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197712966" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197712966">(May 15 2020 at 15:59)</a>:</h4>
<p><span class="user-mention silent" data-user-id="121053">varkor</span> <a href="#narrow/stream/131828-t-compiler/topic/x.2Epy.20concerns/near/197705332">said</a>:</p>
<blockquote>
<p>maybe those changes should have been publicised a bit more</p>
</blockquote>
<p>neat!!</p>



<a name="197713027"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197713027" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197713027">(May 15 2020 at 15:59)</a>:</h4>
<p>I think <span class="user-mention" data-user-id="116266">@Santiago Pastorino</span> a compromise would be to file an issue on rustc-dev-guide</p>



<a name="197713036"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197713036" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197713036">(May 15 2020 at 15:59)</a>:</h4>
<p>and land the PR immediately</p>



<a name="197713882"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197713882" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197713882">(May 15 2020 at 16:05)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116009">nikomatsakis</span> <a href="#narrow/stream/131828-t-compiler/topic/x.2Epy.20concerns/near/197713027">said</a>:</p>
<blockquote>
<p>I think <span class="user-mention silent" data-user-id="116266">Santiago Pastorino</span> a compromise would be to file an issue on rustc-dev-guide</p>
</blockquote>
<p>yes, agreed that this is better but ideally the best solution would be to open a PR</p>



<a name="197714003"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197714003" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197714003">(May 15 2020 at 16:06)</a>:</h4>
<p>so we can collectively own rustc-dev-guide</p>



<a name="197717891"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197717891" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197717891">(May 15 2020 at 16:34)</a>:</h4>
<p>Yeah, the trouble with just filing a PR is that it applies no back pressure, and we have neither the expertise nor the manpower to turn every issue into actual documentation</p>



<a name="197717995"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197717995" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197717995">(May 15 2020 at 16:35)</a>:</h4>
<p>I rather like what <span class="user-mention" data-user-id="118594">@ecstatic-morse</span> did with <a href="https://github.com/rust-lang/rustc-dev-guide/pull/583">https://github.com/rust-lang/rustc-dev-guide/pull/583</a></p>



<a name="197718120"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197718120" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197718120">(May 15 2020 at 16:35)</a>:</h4>
<p>They opened a PR with some documentation and a promise of more later. There's very little chance that we would actually get this documentation if they hadn't volunteered it... <span aria-label="heart" class="emoji emoji-2764" role="img" title="heart">:heart:</span></p>



<a name="197728066"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197728066" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mati865 <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197728066">(May 15 2020 at 17:51)</a>:</h4>
<p><span class="user-mention silent" data-user-id="121053">varkor</span> <a href="#narrow/stream/131828-t-compiler/topic/x.2Epy.20concerns/near/197705168">said</a>:</p>
<blockquote>
<p><span class="user-mention silent" data-user-id="116009">nikomatsakis</span> <a href="#narrow/stream/131828-t-compiler/topic/x.2Epy.20concerns/near/197705087">said</a>:</p>
<blockquote>
<p>I'd lik to see <code>x.py test src/test/ui/foo.rs</code> just work</p>
</blockquote>
<p>it does, doesn't it?</p>
</blockquote>
<p>I tried that like month ago to run just one of ui tests but that didn't work. <code>x.py test src/test/ui</code> ran just ui tests as expected though, so I eventually removed all the tests except the one I needed <span aria-label="shrug" class="emoji emoji-1f937" role="img" title="shrug">:shrug:</span></p>



<a name="197728244"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197728244" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197728244">(May 15 2020 at 17:52)</a>:</h4>
<p>we have <code>--test-args test_name</code> which helps shrink the list of tests that are run, but that's not ideal since it just matches the name and I don't think you can specify full paths</p>



<a name="197729985"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197729985" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Dylan MacKenzie (ecstatic-morse) <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197729985">(May 15 2020 at 18:04)</a>:</h4>
<p><span class="user-mention silent" data-user-id="198054">mark-i-m</span> <a href="#narrow/stream/131828-t-compiler/topic/x.2Epy.20concerns/near/197717995">said</a>:</p>
<blockquote>
<p>I rather like what <span class="user-mention silent" data-user-id="118594">ecstatic-morse</span> did with <a href="https://github.com/rust-lang/rustc-dev-guide/pull/583">https://github.com/rust-lang/rustc-dev-guide/pull/583</a></p>
</blockquote>
<p>I should uhh, probably finish that at some point, although there's one more major change (arbitrary domains) to the API in the works.</p>



<a name="197734294"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197734294" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197734294">(May 15 2020 at 18:38)</a>:</h4>
<p><code>./x.py test src/test/ui/specific-test.rs</code> should work fine, I use that all the time</p>



<a name="197734330"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197734330" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197734330">(May 15 2020 at 18:39)</a>:</h4>
<p>One problem is that globs don't work – all but the first file are ignored</p>



<a name="197734354"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197734354" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197734354">(May 15 2020 at 18:39)</a>:</h4>
<p>Presumably because the rest is passed as arguments to... something?</p>



<a name="197793473"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197793473" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> varkor <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197793473">(May 16 2020 at 12:28)</a>:</h4>
<p><span class="user-mention silent" data-user-id="211727">Jonas Schievink</span> <a href="#narrow/stream/131828-t-compiler/topic/x.2Epy.20concerns/near/197734330">said</a>:</p>
<blockquote>
<p>One problem is that globs don't work – all but the first file are ignored</p>
</blockquote>
<p>I think this specific pattern is special-cased, but I can't remember why supporting multiple files was inconvenient to implement.</p>



<a name="197797697"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197797697" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197797697">(May 16 2020 at 14:18)</a>:</h4>
<p><span class="user-mention" data-user-id="121053">@varkor</span> probably because we have to lower to <code>--test-args</code> and compiletest, like libtest, only accepts a single pattern</p>



<a name="197797737"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/x.py%20concerns/near/197797737" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/x.2Epy.20concerns.html#197797737">(May 16 2020 at 14:18)</a>:</h4>
<p>(and it's a substring match IIRC, not a regex, so you don't get alternations)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>